🧰 Engineering Essentials · Code Quality
Review code like a senior engineer (PHP)
Review order, comment quality, and scope discipline making PRs fast and kind.
foundation~25 minAll Software Engineers
Steps
- 1Read description and tests FIRST to learn intent
- 2Check correctness and security before style nits
- 3Comment questions/observations vs required-changes distinctly
- 4Keep nitpicks batched as one optional pass
- 5Approve explicitly when remaining items are optional
- 6Aim same-day first response; latency kills momentum
- 7Run static analysis (PHPStan/Psalm) at max level in CI
- 8Profile request cycles with Xdebug + cachegrind on real routes
Common Pitfalls
- ▲Style wars the formatter should own
- ▲LGTM rubber-stamps on 2000-line diffs
Commands
Install with skills CLI
$ npx skills add aniruddhaadak80/skills --skill code-quality-code-review-checklist-phpInstall globally
$ npx skills add aniruddhaadak80/skills --skill code-quality-code-review-checklist-php -gTags
#code-review#quality#collaboration#engineering-essentials#code-quality