🧰 Engineering Essentials · Code Quality

Refactor without breaking behavior (PHP)

Characterization tests, small mechanical steps, and clean-cut commits keeping refactors boring.

intermediate~35 minAll Software Engineers

Steps

1Pin current behavior with characterization tests where gaps exist
2Plan steps each leaving tests green; commit per step
3Prefer mechanical moves (extract, inline, rename) over clever rewrites
4Keep behavior changes in separate PRs from structure moves
5Measure complexity delta honestly; stop when readability peaks
6Leave the campsite cleaner but don't rebuild the forest
7Run static analysis (PHPStan/Psalm) at max level in CI
8Profile request cycles with Xdebug + cachegrind on real routes

Common Pitfalls

▲Big-bang rewrites losing hidden behaviors
▲'While I'm here' feature creep inside refactor PRs

Commands

Install with skills CLI

$ npx skills add aniruddhaadak80/skills --skill code-quality-refactor-safely-php

Install globally

$ npx skills add aniruddhaadak80/skills --skill code-quality-refactor-safely-php -g

Tags

#refactoring#legacy-code#engineering-essentials#code-quality

Install this skill

$ npx skills add aniruddhaadak80/skills --skill code-quality-refactor-safely-php -a opencode

SKILL.md

# Refactor without breaking behavior (PHP)

> Characterization tests, small mechanical steps, and clean-cut commits keeping refactors boring.

## When to Use This Skill

Characterization tests, small mechanical steps, and clean-cut commits keeping refactors boring.

## Steps

1. Pin current behavior with characterization tests where gaps exist
2. Plan steps each leaving tests green; commit per step
3. Prefer mechanical moves (extract, inline, rename) over clever rewrites
4. Keep behavior changes in separate PRs from structure moves
5. Measure complexity delta honestly; stop when readability peaks
6. Leave the campsite cleaner but don't rebuild the forest
7. Run static analysis (PHPStan/Psalm) at max level in CI
8. Profile request cycles with Xdebug + cachegrind on real routes

## Common Pitfalls

- Big-bang rewrites losing hidden behaviors
- 'While I'm here' feature creep inside refactor PRs

View source on GitHub ↗

Review order, comment quality, and scope discipline making PRs fast and kind.

🧰 Engineering Essentials·~25m

Open →

Review code like a senior engineer (Python)foundation

Review order, comment quality, and scope discipline making PRs fast and kind.

🧰 Engineering Essentials·~25m

Open →

Review code like a senior engineer (Go)foundation

Review order, comment quality, and scope discipline making PRs fast and kind.

🧰 Engineering Essentials·~25m

Open →